ci: fix go workflow succeeding even if a step fails #5
Conversation
The continue-on-error flag appears to be buggy and not well documented, however it was causing the workflow to be marked as succeded even if a step failed.
joshuasing
added
type: bug
|
hey @joshuasing I am a little confused here; I think I understand the issue we're trying to solve, however why not just leave it with the default? why do we need this |
@ClaytonNorthey92 I had added 'continue-on-error' so that we can collect error logs from each step instead of it exiting immediately when one step failed, aiming to allow us to collect extra information that could be useful for debugging. I was unsure of whether continue-on-error would cause this bug at the time, as different parts of GitHub's documentation said completely different things. |
@joshuasing OK that makes sense. Can we test this before merging? Perhaps push up a broken commit and make sure the pipeline fails correctly with this change? If so, then I approve ✅️ |
|
Hey @joshuasing I saw the breaking test 👍 let's drop that commit and merge |
joshuasing
force-pushed
the
joshua/fix-ci-false-pass
branch
from
1c621a7 to
37a3bd1
Compare
The continue-on-error flag appears to be buggy and not well documented, however it was causing the workflow to be marked as succeded even if a step failed.
Summary
Remove use of
continue-on-errorflag in Go workflow due to it causing the workflow to suceed even if a step failed.Changes
continue-on-errorwithif: (success() || failure()) && steps.deps.outcome == 'success'to mimic behaviour without causing the job to succeed with steps failing.