Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add error handling for cryptographic operations #349

Conversation

crStiv
Copy link

@crStiv crStiv commented Dec 25, 2024

Changes

  • Added custom error types for cryptographic operations
  • Implemented input parameter validation for public keys
  • Added validation for Ethereum addresses
  • Improved error handling during key generation
  • Added signature verification

Testing

  • Verified key generation with invalid parameters
  • Verified address validation
  • Verified handling of invalid signatures

Closes #348

@crStiv crStiv requested a review from a team as a code owner December 25, 2024 16:57
@joshuasing
Copy link
Contributor

Thanks for taking the time to contribute, however at this time we feel these changes are unnecessary. The ethereum package contains Ethereum-related utilities for the rest of the codebase to use, and each function contained within is required by another package in the repository.

Additionally, this pull request does not compile due to it changing functions (and attempting to override the existing PublicKeyToAddress function) that are used within other packages. Error messages within this repository also must contain English characters only.

We have decided to close this for now, however please feel free to create new pull requests if you think there are other parts of the codebase we can improve. Thanks again.

@joshuasing joshuasing closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Management
2 participants