bitcoin finality request+query efficiency #346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area: bfg
ClaytonNorthey92
requested review from
jcvernaleo,
max-sanchez,
marcopeereboom and
joshuasing
marcopeereboom
approved these changes
Dec 18, 2024
ClaytonNorthey92
force-pushed
the
clayton/finality-efficiency
branch
2 times, most recently
from
64912ff to
eef7536
Compare
database/bfgd/postgres/postgres.go
Outdated
| SELECT` + | ||
| // DISTINCT ON returns the first result for each unique l2 block number | ||
| ` | ||
| DISTINCT ON (l2_block_number) |
There was a problem hiding this comment.
this is still a bit inefficient
|
I have to give this a bit more thought; don't merge quite yet |
ClaytonNorthey92
force-pushed
the
clayton/finality-efficiency
branch
from
fa48c63 to
fba541c
Compare
* make "recent finalities" call "finalities by keystone" with recent keystones * remove expensive joins, prefer additional (fast) queries
ClaytonNorthey92
force-pushed
the
clayton/finality-efficiency
branch
from
32f5e53 to
32ebf8e
Compare
joshuasing
approved these changes
Dec 24, 2024
|
still doing some testing before merge 🧑💻 |
|
after some discussion with @max-sanchez , going with a different approach here. the functionality will be quite different and require new reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
see summary