popm: exclude tx outputs that would be dust #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid "dust" errors when broadcasting PoP transactions to Bitcoin by checking if the transaction output would be considered dust with a relay tx fee of 10,000. If the transaction output would be considered dust, then don't include the output and instead leave the remaining to be included as a fee.
joshuasing
added
type: enhancement
joshuasing
requested review from
jcvernaleo,
max-sanchez,
marcopeereboom and
ClaytonNorthey92
|
hey @joshuasing (and maybe @marcopeereboom or @max-sanchez could answer this) why did we choose 10,000 for the |
ClaytonNorthey92
approved these changes
Jul 18, 2024
marcopeereboom
approved these changes
Jul 19, 2024
web3cryptoguy
pushed a commit
to web3cryptoguy/heminetwork
that referenced
this pull request
Nov 1, 2024
Avoid "dust" errors when broadcasting PoP transactions to Bitcoin by checking if the transaction output would be considered dust with a relay tx fee of 10,000. If the transaction output would be considered dust, then don't include the output and instead leave the remaining to be included as a fee.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Avoid "dust" errors when broadcasting PoP transactions to Bitcoin by checking if the transaction output would be considered dust with a relay tx fee of 10,000.
If the transaction output would be considered dust, then don't include the output and instead leave the remaining to be included as a fee.
Fixes #183
Changes