remove lastErr variables from rpc_test.go #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClaytonNorthey92
force-pushed
the
clayton/staticcheck-lasterr
branch
from
79b8000 to
1703823
Compare
joshuasing
added
type: refactor
joshuasing
requested changes
Jul 16, 2024
joshuasing
reviewed
Jul 18, 2024
joshuasing
approved these changes
Jul 22, 2024
lastErr was added to handle for something that likely shouldn't have been; it's an un-needed way to handle for errors. replace with simply failing the test if there are errors. fixes #182
Co-authored-by: Joshua Sing <[email protected]>
Co-authored-by: Joshua Sing <[email protected]>
ClaytonNorthey92
force-pushed
the
clayton/staticcheck-lasterr
branch
from
53d265f to
8f93b5e
Compare
marcopeereboom
previously requested changes
Jul 29, 2024
service/tbc/rpc_test.go
Outdated
| t.Fatal(err) | ||
| } | ||
|
|
||
| if err := tbcServer.UtxoIndexer(ctx, &hash); err != nil { | ||
| if err = tbcServer.UtxoIndexer(ctx, &hash); err != nil { |
There was a problem hiding this comment.
When using this idiom you really should keep :=.
There was a problem hiding this comment.
ah yes will fix
There was a problem hiding this comment.
@joshuasing @marcopeereboom I am ok with either way; you two decide 👍
max-sanchez
approved these changes
Aug 5, 2024
ClaytonNorthey92
dismissed
marcopeereboom’s stale review
OOO - addressed feedback
web3cryptoguy
pushed a commit
to web3cryptoguy/heminetwork
that referenced
this pull request
Nov 1, 2024
* remove lastErr variables from rpc_test.go lastErr was added to handle for something that likely shouldn't have been; it's an un-needed way to handle for errors. replace with simply failing the test if there are errors. fixes hemilabs#182 * removed un-needed for loops * bump test timeout * re-added needed break * surround break in else for readability * tune timeout back to 1 minute * lint * Update service/tbc/rpc_test.go Co-authored-by: Joshua Sing <[email protected]> * Update service/tbc/rpc_test.go Co-authored-by: Joshua Sing <[email protected]> * cleanup from pr feedback * fixed error checking based on feedback * handle write errors differently in tests * get rid of some shadowing * more code cleanup * fixed test * trying larger wait * fix byte order * pr feedback --------- Co-authored-by: Joshua Sing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
lastErr was added to handle for something that likely shouldn't have been; it's an un-needed way to handle for errors. replace with simply failing the test if there are errors.
Changes
remove lastErr variables from rpc_test.go
fixes #182