Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix concurrency cancel-in-progress for pull requests #16

Merged
merged 1 commit into from
Mar 7, 2024
Merged

ci: fix concurrency cancel-in-progress for pull requests #16

merged 1 commit into from
Mar 7, 2024

Conversation

joshuasing
Copy link
Contributor

Summary
Fix previous "Go" CI runs not being cancelled when a newer commit is pushed to a pull request.

Changes

  • Use github.event_name instead of github.event.action in cancel-in-progress

@joshuasing joshuasing added type: bug This is a bug area: ci This is a change to CI files. Excluded from changelog labels Feb 29, 2024
@joshuasing joshuasing added the size: XS This change is very small (+/- <10) label Feb 29, 2024
jcvernaleo
jcvernaleo approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@joshuasing joshuasing merged commit ed7eb8e into main Mar 7, 2024
1 check passed
@joshuasing joshuasing deleted the joshua/ci-cancel-fix branch March 7, 2024 16:39
web3cryptoguy pushed a commit to web3cryptoguy/heminetwork that referenced this pull request Nov 1, 2024
@joshuasing
ci: fix concurrency cancel-in-progress for pull requests (hemilabs#16)
4f434c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClaytonNorthey92 ClaytonNorthey92 ClaytonNorthey92 approved these changes

@jcvernaleo jcvernaleo jcvernaleo approved these changes

@marcopeereboom marcopeereboom Awaiting requested review from marcopeereboom

@max-sanchez max-sanchez Awaiting requested review from max-sanchez

Assignees
No one assigned
Labels
area: ci This is a change to CI files. Excluded from changelog size: XS This change is very small (+/- <10) type: bug This is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuasing @jcvernaleo @ClaytonNorthey92