Use hemilabs/websocket fork of nhooyr.io/websocket #153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use https://github.com/hemilabs/websocket fork of
nhooyr.io/websocket
libraryThe WASM implementation of the WebSocket connection in
nhooyr.io/websocket
contains a bug that causesnet.ErrClosed
to always be returned when the connection is closed, meaning the underlyingwebsocket.CloseError
to never be returned and we can't retrieve the close code or reason. This fork contains a fix that returns the close error correctly. This patch will hopefully be upstreamed at a later date, once we are able to confirm that this fix is working correctly and doesn't change anything else.Tested by running the
web/integrationtest
and providing a private key that is not authorised on the BFG server.The exit behaviour now matches the
popmd
daemon.Changes
github.com/hemilabs/websocket
instead ofnhooyr.io/websocket
(likely temporarily)