Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockscout var updates #23

Closed
wants to merge 5 commits into from

Conversation

dhidalgX
Copy link

@dhidalgX dhidalgX commented Oct 10, 2024

  • Fixing an error from blockscout:
2024-10-10T15:50:44.612126Z ERROR stats_server: service failed with error: Blockscout API URL has not been provided. Please specify it with corresponding env variable (`STATS__BLOCKSCOUT_API_URL`) or set `STATS__IGNORE_BLOCKSCOUT_API_ABSENCE=true` to disable functionality depending on the API.    
Error: Blockscout API URL has not been provided. Please specify it with corresponding env variable (`STATS__BLOCKSCOUT_API_URL`) or set `STATS__IGNORE_BLOCKSCOUT_API_ABSENCE=true` to disable functionality depending on the API.
  • Adding variable to common-blockscout.env to fix the error.
  • Updating URL endpoints.
  • Updating TESTNET Deployment

docker-compose/envs/common-blockscout.env Outdated Show resolved Hide resolved
docker-compose/envs/common-blockscout.env Outdated Show resolved Hide resolved
@@ -25,3 +25,5 @@ STATS__JAEGER__AGENT_ENDPOINT=localhost:6831

STATS__TRACING__ENABLED=true
STATS__TRACING__FORMAT=default

STATS__IGNORE_BLOCKSCOUT_API_ABSENCE=true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we using a newer version of the stats service than the one we tested when forked and deployed Blockscout? If so, the newer version may need additional requirements, therefore the error shown in the logs.

The version used is managed by the STATS_DOCKER_TAG variable in docker-compose/services/stats.yml.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabmontes i think the image for stats is set to :latest as default...

ghcr.io/blockscout/stats:latest 

No updates from our end other tan the actual fix for the error we got... and we applied the fix based on the information from the error log.

Please specify it with corresponding env variable (`STATS__BLOCKSCOUT_API_URL`) or set `STATS__IGNORE_BLOCKSCOUT_API_ABSENCE=true` to disable functionality depending on the API.

cc: @max-sanchez

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try setting STATS__BLOCKSCOUT_API_URL to https://testnet.explorer.hemi.xyz/api?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabmontes Is this setting tested already or do you need me to test it?

dhidalgX and others added 2 commits October 10, 2024 14:27
@dhidalgX dhidalgX requested a review from gabmontes October 10, 2024 20:38
Copy link
Author

@dhidalgX dhidalgX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submit review

@@ -25,3 +25,5 @@ STATS__JAEGER__AGENT_ENDPOINT=localhost:6831

STATS__TRACING__ENABLED=true
STATS__TRACING__FORMAT=default

STATS__IGNORE_BLOCKSCOUT_API_ABSENCE=true
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabmontes i think the image for stats is set to :latest as default...

ghcr.io/blockscout/stats:latest 

No updates from our end other tan the actual fix for the error we got... and we applied the fix based on the information from the error log.

Please specify it with corresponding env variable (`STATS__BLOCKSCOUT_API_URL`) or set `STATS__IGNORE_BLOCKSCOUT_API_ABSENCE=true` to disable functionality depending on the API.

cc: @max-sanchez

docker-compose/envs/common-blockscout.env Outdated Show resolved Hide resolved
Comment on lines +16 to +19
host: ${{ secrets.TESTNET_SSH_HOST }}
username: ${{ secrets.TESTNET_SSH_USER }}
key: ${{ secrets.TESTNET_SSH_KEY }}
port: ${{ secrets.TESTNET_SSH_PORT }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not optimal. See my comments in #22.

@gabmontes gabmontes deleted the branch production-optimism-stg January 13, 2025 15:09
@gabmontes gabmontes closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants