-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blockscout var updates #23
Conversation
dhidalgX
commented
Oct 10, 2024
•
edited
Loading
edited
- Fixing an error from blockscout:
- Adding variable to common-blockscout.env to fix the error.
- Updating URL endpoints.
- Updating TESTNET Deployment
@@ -25,3 +25,5 @@ STATS__JAEGER__AGENT_ENDPOINT=localhost:6831 | |||
|
|||
STATS__TRACING__ENABLED=true | |||
STATS__TRACING__FORMAT=default | |||
|
|||
STATS__IGNORE_BLOCKSCOUT_API_ABSENCE=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we using a newer version of the stats service than the one we tested when forked and deployed Blockscout? If so, the newer version may need additional requirements, therefore the error shown in the logs.
The version used is managed by the STATS_DOCKER_TAG
variable in docker-compose/services/stats.yml
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gabmontes i think the image for stats is set to :latest
as default
...
ghcr.io/blockscout/stats:latest
No updates from our end other tan the actual fix for the error we got... and we applied the fix based on the information from the error log.
Please specify it with corresponding env variable (`STATS__BLOCKSCOUT_API_URL`) or set `STATS__IGNORE_BLOCKSCOUT_API_ABSENCE=true` to disable functionality depending on the API.
cc: @max-sanchez
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try setting STATS__BLOCKSCOUT_API_URL
to https://testnet.explorer.hemi.xyz/api
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gabmontes Is this setting tested already or do you need me to test it?
Updating Subnetwork Co-authored-by: Gabriel Montes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submit review
@@ -25,3 +25,5 @@ STATS__JAEGER__AGENT_ENDPOINT=localhost:6831 | |||
|
|||
STATS__TRACING__ENABLED=true | |||
STATS__TRACING__FORMAT=default | |||
|
|||
STATS__IGNORE_BLOCKSCOUT_API_ABSENCE=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gabmontes i think the image for stats is set to :latest
as default
...
ghcr.io/blockscout/stats:latest
No updates from our end other tan the actual fix for the error we got... and we applied the fix based on the information from the error log.
Please specify it with corresponding env variable (`STATS__BLOCKSCOUT_API_URL`) or set `STATS__IGNORE_BLOCKSCOUT_API_ABSENCE=true` to disable functionality depending on the API.
cc: @max-sanchez
host: ${{ secrets.TESTNET_SSH_HOST }} | ||
username: ${{ secrets.TESTNET_SSH_USER }} | ||
key: ${{ secrets.TESTNET_SSH_KEY }} | ||
port: ${{ secrets.TESTNET_SSH_PORT }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not optimal. See my comments in #22.