Add support for EIP-4844 blobs #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dule of the same rollup
…9377) * feat: batch address selects and preloads * fix: review comments * chore: changelog
…lues-in-token-update Filter empty values before token update
…listinternal, tokentx (blockscout#9364) * Fix using of startblock/endblock in API v1 list endpoints: txlist, txlistinternal, tokentx * Add CHANGELOG entry
* chore: bump actions/cache to v4 * chore: changelog
* Minimal Proxy (blockscout#9365) Co-authored-by: gimlu <[email protected]> * Add CHANGELOG, fix tests * Clear GA cache and refactoring --------- Co-authored-by: GimluCom <[email protected]> Co-authored-by: gimlu <[email protected]>
Change introduced in 0a33a29 but not present in current branch HEADs.
gabmontes
requested review from
gndelia,
jcvernaleo,
max-sanchez and
leanazulyoro
gabmontes
force-pushed
the
add-eip-4844
branch
2 times, most recently
from
a2c306e to
fbae32f
Compare
jcvernaleo
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #9.
Motivation
To support EIP-4844 blobs, changes from version 5.3.1 to 6.3.0 were pulled from upstream and merged into this repository. See the changelog for details.
Details
These commits/PRs were pulled from upstream:
During the merge, several files and code that was moved around and renamed in upstream was incorrectly kept around. To solve this, b98c721 cleaned everything up and ensured the only differences between Hemi and upstream are changes related to Hemi.
Finally, some improvements to the tests and docs were added in f4d506e and a35b4a8 so all relevant tests and checks now pass.
Note: Additional upstream changes and configuration settings may be needed to fully support blobs as the code seems to enable that support only for the "ethereum" chain type while Hemi uses the "optimism" type. Enabling both types at the same time seems not to be an option either in the latest version of Blockscout.
Testing
Local tests showed the services run without errors and blockchain data is ingested and exposed properly through the API.
Note that the failure of many GitHub Actions checks is actually expected and those were not marked as "required" for that reason.
Upgrading
Postgres was updated from version 14 to 15. It is possible that the current database needs to be cleared and rebuilt if the migrations fail to upgrade the schemas automatically.