Merge pull request canonical#318 from gboutry/tests/warnings

tests: fix test warnings
hemanthnakkina · Aug 25, 2024 · 6d07915 · 6d07915
2 parents 4085d4d + 760842d
commit 6d07915
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/sunbeam-python/tests/unit/sunbeam/commands/test_microceph.py b/sunbeam-python/tests/unit/sunbeam/commands/test_microceph.py
@@ -109,6 +109,7 @@ def test_is_skip_with_storage_nodes(self, cclient, jhelper):
         assert result.result_type == ResultType.COMPLETED
 
     def test_run(self, cclient, jhelper):
+        jhelper.run_action.return_value = Mock()
         step = SetCephMgrPoolSizeStep(cclient, jhelper, "test-model")
         result = step.run()
 

diff --git a/sunbeam-python/tests/unit/sunbeam/test_clusterd.py b/sunbeam-python/tests/unit/sunbeam/test_clusterd.py
@@ -54,10 +54,8 @@ def test_init_step(self, cclient, mocker):
         init_step = ClusterInitStep(cclient, [role], 0, "10.0.0.0/16")
         init_step.client = MagicMock()
         init_step.fqdn = "node1"
-        with mocker.patch(
-            "sunbeam.utils.get_local_ip_by_cidr", return_value="10.0.0.2"
-        ):
-            result = init_step.run()
+        mocker.patch("sunbeam.utils.get_local_ip_by_cidr", return_value="10.0.0.2")
+        result = init_step.run()
         assert result.result_type == ResultType.COMPLETED
         init_step.client.cluster.bootstrap.assert_called_once()