Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STYLE: changing text for explanation tab #313

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

hina-shah
Copy link
Contributor

Trying to make the concept card text a little more clearer. The text was suggested and reviewed by DUG team members.

Copy link
Collaborator

@frostyfan109 frostyfan109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

</Text>
<div>
<Text style={{ fontSize: 13 }} italic>Why am I seeing this result?</Text>
<Text style={{ fontSize: 13 }} italic>What does the total score returned by the search mean??</Text>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are two ? intended?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hina-shah this was pushed through, did you mean to do this??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no, I'm sorry no. But I see that you fixed it. Thanks!

@@ -172,10 +172,10 @@ export const ExplanationTab = ({ result }) => {
fontSize: 15,
fontWeight: 500
}}>
Score breakdown
Explanation for this concept&apos;s relation to search term
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems wordy? But I've got no issue if this is what we've come to consensus on

@hina-shah hina-shah merged commit a8161a0 into develop Sep 10, 2024
6 checks passed
@hina-shah hina-shah deleted the enh-concept-card branch September 10, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants