Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed console.log to openNotification.. when refering to API calls #309

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pchachicho
Copy link
Contributor

No description provided.

@pchachicho pchachicho requested a review from frostyfan109 June 29, 2024 17:16
@frostyfan109
Copy link
Collaborator

frostyfan109 commented Jul 19, 2024

@pchachicho sorry it took so long for me to get to this. this pr is on the right track, but there are a lot of other usages of the workspaces API throughout the UI components (for reference). Some of these don't need error messages (e.g. in app-card, we don't need to show a message if the app fails, since that's handled elsewhere) but the majority do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants