ENH: Adding study linkages to CDE tab in concept card #308
Conversation
There was a problem hiding this comment.
The code looks great! I have some suggestions for the UX (and one very minor code suggestion), but I'm not sure if we want to do that in this PR or if it would be better to do that in a separate PR. My suggestions would be:
- I don't think related studies is as important as the description; instead, I'd reduce the font size a bit so it was similar in size to the "Related concepts".
- The related studies list can be pretty long -- I would either display only the first three entries followed by a "show more" button or collapse this entire section.
Also I notice that the Highlighter can't be used to search by Study Title -- that would be useful to have, but not critical for this PR. I think we should open a ticket for that and work on it separately.
…on of showing more studies if requested
|
@gaurav : I've pushed requested changes to the related study list. |
This only shows up if someone enters the TranQL URL incorrect (guess how I found this).
|
@hina-shah Thanks for working on this, Hina! I found a bug in the TranQL query for CDEs and fixed that, and then made a few minor improvements to the studies display. Have a look and let me know what you think -- and feel free to remove any of my "improvements" if you disagree! My previous approval still stands :) |
|
Thanks @gaurav ! |
|
@hina-shah If @frostyfan109 approves of this PR, I think it's good to merge -- I'd love to see what it looks like in Dev and to get more feedback from other HEAL folks! |
Showing studies that use CDEs displayed in the concept card of concept search.