Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QR for non tall-skinny matrices and split=0 #1744

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

QR for non tall-skinny matrices and split=0 #1744

wants to merge 7 commits into from

Conversation

mrfh92
Copy link
Collaborator

@mrfh92 mrfh92 commented Dec 9, 2024 •
edited
Loading

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • benchmarks: created for new functionality (currently not available)
    • benchmarks: performance improved or maintained (currently not available)
    • documentation updated where needed

Description

see title

Issue/s resolved: #1736

Does this change modify the behaviour of other functions? If so, which?

no

@mrfh92 mrfh92 marked this pull request as ready for review December 9, 2024 16:39
@mrfh92 mrfh92 added linalg ESAPCA relevant for the ESA-funded project "ESAPCA" labels Dec 9, 2024
@mrfh92 mrfh92 self-assigned this Dec 9, 2024
@mrfh92 mrfh92 added the enhancement New feature or request label Dec 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Thank you for the PR!

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Thank you for the PR!

Hoppe added 2 commits December 10, 2024 10:18
debugging
3a77070
Merge branch 'features/1736-QR_for_non-tall-skinny_matrices_and_split…
b6bd730 
…=0' of github.com:helmholtz-analytics/heat into features/1736-QR_for_non-tall-skinny_matrices_and_split=0
@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.27%. Comparing base (443afe3) to head (d7f4be5).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1744      +/-   ##
==========================================
+ Coverage   92.26%   92.27%   +0.01%     
==========================================
  Files          84       84              
  Lines       12445    12471      +26     
==========================================
+ Hits        11482    11508      +26     
  Misses        963      963
Flag Coverage Δ
unit 92.27% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrfh92 mrfh92 mentioned this pull request Dec 10, 2024
Open
6 tasks
@mrfh92
Copy link
Collaborator Author

mrfh92 commented Dec 10, 2024

needs to be merged before #1697

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@mrfh92 mrfh92 added the PR talk label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClaudiaComito ClaudiaComito Awaiting requested review from ClaudiaComito

@Hakdag97 Hakdag97 Awaiting requested review from Hakdag97

At least 1 approving review is required to merge this pull request.

Assignees

@mrfh92 mrfh92

Labels
enhancement New feature or request ESAPCA relevant for the ESA-funded project "ESAPCA" linalg PR talk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QR for non-tall-skinny matrices and split=0
1 participant
@mrfh92