chore: Add build workflow for sdkexamples #1657
Conversation
There was a problem hiding this comment.
Great addition to #1543!
Can you also add sdkexamples/sdkexamples to .gitignore for good measure?
Either way, lgtm 👍
TerryHowe
force-pushed
the
build-sdkexamples
branch
from
ac17e3f to
3351c58
Compare
Added |
Makefile
Outdated
| @@ -23,6 +23,10 @@ run-link-checker: | |||
|
|
|||
| check-links-ci: set-up-link-checker run-link-checker | |||
|
|
|||
| .PHONY: sdkexamples | |||
| sdkexamples: | |||
| cd sdkexamples; make | |||
There was a problem hiding this comment.
In case you didn't know make -C sdkexamples would work too :)
.github/workflows/build.yml
Outdated
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| go-version: ['1.23'] |
There was a problem hiding this comment.
do we need to pin this, or can/should we default to "latest" ?
There was a problem hiding this comment.
We could do latest, add multiple versions of Go to the matrix, also give a server range if we wanted, per https://github.com/actions/setup-go (eg >=1.23). But agree this can be a follow-up PR, and can revisit this whenever we feel the check should have more specific requirements. Mainly this PR helps make sure these SDK examples continue to build properly
There was a problem hiding this comment.
It contains these changes plus the requested changes
There was a problem hiding this comment.
I had one approval and I didn't want to reset that
There was a problem hiding this comment.
Moved those changes to this PR
Signed-off-by: Terry Howe <[email protected]>
TerryHowe
force-pushed
the
build-sdkexamples
branch
from
e3a3bd0 to
5b7c526
Compare
Signed-off-by: Terry Howe <[email protected]>
TerryHowe
force-pushed
the
build-sdkexamples
branch
from
5b7c526 to
d9aa321
Compare
Add a build test for sdkexamples