Properly handle windows-style newlines \r\n
#59
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #58 by checking for the presence of a carriage return
\r
and defaulting to Unicode handling in that situation.The carriage return only check implemented here has maybe 10% performance hit on short ASCII strings; other solutions that I tried resulted in 10-20% performance differences. (The std
is_ascii
implementation is very optimized.)Technically this could result in some false positives which means more grapheme iteration. I'm not sure what the most desirable solution here is. It is unclear to me that it is worth special-casing
\r\n
handling at the cost of normal code paths.Is it worth optimizing for ASCII only? How much better is ASCII performance, vs
Vec<char>
performance, in the matcher?