Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize url params updates #860

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

JayJay1024
Copy link
Collaborator

@JayJay1024 JayJay1024 commented Nov 4, 2024

PR-Codex overview

This PR focuses on enhancing the TransferProvider component by introducing state management for user interactions with URL parameters. It improves the handling of token and chain selections and ensures that changes are tracked accurately to manage navigation effectively.

Detailed summary

  • Added isOpenedWithoutUrlParams, hasUserManuallyChangedTokenParams, and hasUserManuallyChangedOtherParams refs.
  • Updated token and chain selection logic to store options in separate variables.
  • Modified changeUrl function to conditionally navigate based on user interactions.
  • Updated handling functions (handleTokenChange, handleSourceChainChange, etc.) to set flags for manual changes.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Nov 4, 2024

⚠️ No Changeset found

Latest commit: f0af684

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 4, 2024

@JayJay1024 JayJay1024 merged commit 63adf60 into main Nov 4, 2024
2 checks passed
@JayJay1024 JayJay1024 deleted the jay/optimize-url-params-updates branch November 4, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant