-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deployment info to gateway_metadata #430
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,10 +21,35 @@ import "reward_manifest.proto"; | |
// - Keypair fields are binary encoded public keys, Rust encoding example here: | ||
// https://github.com/helium/helium-crypto-rs/blob/main/src/public_key.rs#L347-L354 | ||
|
||
message wifi_deployment_info { | ||
// antenna id | ||
uint32 antenna = 1; | ||
// The height of the hotspot above ground level in whole meters | ||
uint32 elevation = 2; | ||
uint32 azimuth = 3; | ||
uint32 mechanical_down_tilt = 4; | ||
uint32 electrical_down_tilt = 5; | ||
} | ||
|
||
message cbrs_deployment_info { | ||
repeated radio_deployment_info radio_deployment_info = 1; | ||
} | ||
|
||
message radio_deployment_info { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prepend CBRS to this message? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It makes sense, I will |
||
// CBSD_ID or radio | ||
string radio_id = 1; | ||
// The asserted elevation of the gateway above ground level in whole meters | ||
uint32 elevation = 2; | ||
} | ||
|
||
message gateway_metadata { | ||
// The res12 h3 index asserted address of the gateway as a string | ||
// where an unasserted gateway returns an empty string | ||
string location = 2; | ||
oneof deployment_info { | ||
wifi_deployment_info wifi_deployment_info = 3; | ||
cbrs_deployment_info cbrs_deployment_info = 4; | ||
} | ||
} | ||
|
||
message gateway_info { | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add comments for each field here providing some context of each field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about that but nothing comes to mind except obvious: "Antenna azimuth" (etc)