add too late reason #385
Merged
add too late reason #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andymck
force-pushed
the
andymck/support-too-late-invalid-reason
branch
from
659aa0c to
6f4e950
Compare
bbalser
approved these changes
Jan 9, 2024
| @@ -39,6 +39,7 @@ enum invalid_reason { | |||
| below_min_distance = 19; | |||
| duplicate = 20; | |||
| denied_edge = 21; | |||
| too_late = 22; | |||
There was a problem hiding this comment.
what's the difference between too_late and stale?
There was a problem hiding this comment.
too late is specific to the new verification to check the time between a report and a POC's first event.
stale is for a report which has not been processed by the runner after a max time and gets purged by the purger
|
Maybe add these clarifications to a comment
…On Thu, Jan 11, 2024 at 08:23 andymck ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/service/poc_lora.proto
<#385 (comment)>:
> @@ -39,6 +39,7 @@ enum invalid_reason {
below_min_distance = 19;
duplicate = 20;
denied_edge = 21;
+ too_late = 22;
too late is specific to the new verification to check the time between a
report and a POC's first event.
stale is for a report which has not been processed by the runner after a
max time and gets purged by the purger
—
Reply to this email directly, view it on GitHub
<#385 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACZBUNFLEFFAQZ4KDUSPTYN7YUTAVCNFSM6AAAAABBOSTLIOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMJVG4YTMOJVGE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
I will add a follow up PR to add comments to each reason...we have an early explanation of each on the oracle readme which has become inevitably stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.