Helium Lib attempt: 2 #930
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldjeffrey
force-pushed
the
mj/helium-lib-2
branch
from
2e366ad to
92d81de
Compare
Remove test mocks, or move them to unit tests where applicable
now we can remove the ignore from testing confirmed txns
It's the only place it's still used, and a sender is being worked on that will use the same name.
The work done is helium-lib is useful, but not quite what we were looking for. The change still allows us to clean up quite a bit within Oracles though, so we can still use it.
When we submit to solana, we move the existing data transfer sessions to a pending table. When the txn is finalized, we write those to s3 from the pending table and delete. We do this move so the Daemon can continue to ingest s3 files without making them indistinguishable from pending txns.
- unneeded lifetimes - unnecessary references - box large Error
michaeldjeffrey
force-pushed
the
mj/helium-lib-2
branch
from
92d81de to
a7116be
Compare
bbalser
reviewed
Jan 22, 2025
we want to put the server in a place to write out verified data transfer sessions, even if it cannot burn. fixup to always confirm before burning
This is a relatively big query, and it is nice to not have to keep multiple copies of it in sync. first_timestamp was added to handle the case where pending data transfer sessions are being moved back to the regular data transfer sessions table.
michaeldjeffrey
force-pushed
the
mj/helium-lib-2
branch
from
e9b1181 to
a09b1d7
Compare
bbalser
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a doozy!
The initial swing at using
helium-libin Oracles was intended only for the constructing of transactions.It then moved into also using
helium-libfor sending and finalizing transactions, as there were issues with trusting when Solana said a transaction was finalized.Much of the work in this PR was a result of that attempt. It wasn't quite what was considered useful for
helium-lib, but it did provide a baseline for shoring up burn transaction in Oracles.Use
helium-libfor constructing transactionhexboosting::start_boostinboost_managerdc::burn_delegatediniot_packet_verifierandmobile_packet_verifieriot_packet_verifierupdatessqlxinstead of mocksimpl TxnStorefor tracking transactionssolanaworkspace providedTestSolanaClientMapfor Solana mock instead of local mockmobile_packet_verifierupdatespending_txns.sqlmigration for tracking pending txns in a similar style toiot_packet_verifierconfirm_pending_txnson startupimpl TxnStorefor tracking transactionssolanaworkspace providedTestSolanaClientMapfor Solana mock instead of local mocksolanaupdatesSolanaRpctakes it'sSubDaoas an argumentburn::test_client::TestSolanaClientMapfor testingsendermodule for breaking out how to track burn transactionsTransactionwrapper for(SolanaTransaction, BlockHeight)send_with_retry!macro intostart_boostuntil it also uses aTxnStorefor retrying.Thoughts for upcoming PRs
PendingTxncould be consolidated betweeniot_packet_verifierandmobile_packet_verifierintosolana, but they are currently not similar enough to feel comfortable doing that.helium-libhandling send/retry/finalize logic for users.