HIP-134 unique connections #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldjeffrey
force-pushed
the
mj/hip-134-unique-connections
branch
from
1e31079 to
c44c915
Compare
andymck
reviewed
Dec 3, 2024
|
Got a clippy issue |
michaeldjeffrey
force-pushed
the
mj/hip-134-unique-connections
branch
from
c44c915 to
f3227e0
Compare
macpie
approved these changes
Dec 4, 2024
michaeldjeffrey
force-pushed
the
mj/hip-134-unique-connections
branch
from
f3227e0 to
18649e7
Compare
andymck
reviewed
Dec 6, 2024
bbalser
reviewed
Dec 6, 2024
andymck
approved these changes
Dec 9, 2024
while it currently comes from the radio-threshold service, and it feelslike a threshold for a radio to pas for rewarding; current radio thresholds is about service provider boosting, and unique connections is about oracle boosting.
this makes sure we're idempotent when reprocessing reports within the same day.
…se for a record If we get sent a new report in the same day, we always want to use the latest supplied number.
If we get sent a new report in the same day, we always want to use the latest supplied number.
The old distinct on was returning all rows for a pubkey in reverse order, so the latest value was always inserted into the hashmap last. Now, we are correctly getting a single value for a pubkey that is the latest by timestamp. Thank you Brian.
If we use inclusive on the end date, we may use a previous days record for the current day when we do not mean to.
batch inserting is more performant from the IO perspective.
send oracle boosting status in reward_v2. sp boosted status has been renamed to reduce confusion. orable boost status has been added
michaeldjeffrey
force-pushed
the
mj/hip-134-unique-connections
branch
from
cf6fb1e to
e54db09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a wifi hotspot has >25 unique connections of a 7 day rolling period, it automatically gets a
1xOracle Boosting multiplier.It is are exempt from Service Provider Banning.
Update Coverage Point Calculator
OracleBoostingStatus::Qualifiedvariant.This variant is constructed when a wifi radios has >25 unique connections over a 7 day rolling period as submitted by the CDR processing service to the ingestor.
New Ingestor
UniqueConnectionsIngestor.Verifies a
unique_connections_ingest_report_v1carrier_key, writes outverified_unique_connections_ingest_report_v1and saves unique counts to mobile-verifiers db for next rewards epoch.New db table
unique_connectionstableStores unique connection reports received from the CDR processing service. Counts represent unique connections for a wifi hotspots over a 7 day rolling period.
The rewarder clears this table after rewarding keeping a days extra worth of data for reprocessing.