Skip to content

Commit

Permalink
fix test
Browse files Browse the repository at this point in the history
  • Loading branch information
heesung-sn committed Nov 1, 2024
1 parent f5991a8 commit d86cf6c
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
1 change: 0 additions & 1 deletion pulsar-inttest-client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@
<artifactId>pulsar-client-admin-api</artifactId>
<version>${project.version}</version>
</dependency>

</dependencies>

<build>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ public static String getNonPartitionedTopic(PulsarAdmin admin, String topicPrefi
throws Exception {
String nsName = generateNamespaceName();
admin.namespaces().createNamespace("public/" + nsName);
return generateTopicName(nsName, topicPrefix, isPersistent);

//TODO: Pass isPersistent, reported in https://github.com/apache/pulsar/issues/23541
return generateTopicName(nsName, topicPrefix, true);
}

public static String getPartitionedTopic(PulsarAdmin admin, String topicPrefix, boolean isPersistent,
Expand All @@ -68,7 +70,9 @@ public static String getPartitionedTopic(PulsarAdmin admin, String topicPrefix,
}
String nsName = generateNamespaceName();
admin.namespaces().createNamespace("public/" + nsName);
String topicName = generateTopicName(nsName, topicPrefix, isPersistent);

//TODO: Pass isPersistent, reported in https://github.com/apache/pulsar/issues/23541
String topicName = generateTopicName(nsName, topicPrefix, true);
admin.topics().createPartitionedTopic(topicName, partitions);
return topicName;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,17 @@ protected String getNonPartitionedTopic(String topicPrefix, boolean isPersistent
String nsName = generateNamespaceName();
pulsarCluster.createNamespace(nsName);

return generateTopicName(nsName, topicPrefix, isPersistent);
//TODO: Pass isPersistent, reported in https://github.com/apache/pulsar/issues/23541
return generateTopicName(nsName, topicPrefix, true);
}

protected String getPartitionedTopic(String topicPrefix, boolean isPersistent, int partitions) throws Exception {
assertTrue(partitions > 0, "partitions must greater than 1");
String nsName = generateNamespaceName();
pulsarCluster.createNamespace(nsName);

String topicName = generateTopicName(nsName, topicPrefix, isPersistent);
//TODO: Pass isPersistent, reported in https://github.com/apache/pulsar/issues/23541
String topicName = generateTopicName(nsName, topicPrefix, true);
pulsarCluster.createPartitionedTopic(topicName, partitions);
return topicName;
}
Expand Down

0 comments on commit d86cf6c

Please sign in to comment.