Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📜 Workbook fixes, removes old structure #5952

Merged
merged 17 commits into from
Nov 24, 2024
Merged

📜 Workbook fixes, removes old structure #5952

merged 17 commits into from
Nov 24, 2024

Conversation

Felienne
Copy link
Member

@Felienne Felienne commented Nov 20, 2024

Removes the old workbooks and fixes a date type issue in nl

@boryanagoncharenko boryanagoncharenko self-assigned this Nov 21, 2024
Copy link
Contributor

mergify bot commented Nov 21, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@Felienne Felienne marked this pull request as draft November 21, 2024 09:53
@Felienne
Copy link
Member Author

Thanks for the approve Boryana, but I should have made this a draft since it still needs to be translated

@boryanagoncharenko
Copy link
Collaborator

Thanks for the approve Boryana, but I should have made this a draft since it still needs to be translated

Oh no, I am very sorry. It did appear in my non-draft PR filter, so I reviewed it and even pushed a merge conflict resolving commit. Sorry, I hope this does not mess things up too much.

@boryanagoncharenko boryanagoncharenko removed their assignment Nov 21, 2024
@boryanagoncharenko boryanagoncharenko dismissed their stale review November 21, 2024 10:19

The PR was not for review just yet

@Felienne
Copy link
Member Author

Thanks for the approve Boryana, but I should have made this a draft since it still needs to be translated

Oh no, I am very sorry. It did appear in my non-draft PR filter, so I reviewed it and even pushed a merge conflict resolving commit. Sorry, I hope this does not mess things up too much.

No my bad! I should have made it draft!

@Felienne
Copy link
Member Author

Ready for @MarleenGilsing to translate <3

@MarleenGilsing MarleenGilsing self-assigned this Nov 22, 2024
@Felienne Felienne changed the title 📜 Adds workbook 8, removes old structure 📜 Workbook fixes, removes old structure Nov 23, 2024
@Felienne Felienne marked this pull request as ready for review November 23, 2024 19:33
@Felienne
Copy link
Member Author

@boryanagoncharenko I removed the level 8 workbooks here so we can merge these fixes (should not have been one PR, sorry) will make a new PR with just level 8.

@Felienne Felienne merged commit 7aeaacd into main Nov 24, 2024
9 checks passed
@Felienne Felienne deleted the workbook-8 branch November 24, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants