Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 Small changes to the create accounts in bulk interface #5914

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

boryanagoncharenko
Copy link
Collaborator

This PR addresses the feedback for create student accounts in bulk feature.

Fixes #5886

How to test

  • When a username contains forbidden characters @ or :, the error message should point out the incorrect usernames.
  • The font of the table containing the usernames and passwords should be with a monospace font, so that zero is different than a capital o.
  • The height of the table that will be printed should be high, so that around 10 student accounts could fit in.

Copy link
Member

@Felienne Felienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

mergify bot commented Nov 7, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Nov 7, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 523e6b8 into main Nov 7, 2024
11 checks passed
@mergify mergify bot deleted the create_accouts_5886 branch November 7, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🪲 Make changes to the create student accounts in bulk
2 participants