Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not specify tagprefix since there is none in tags for hed-python #1034

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

yarikoptic
Copy link
Contributor

Without it "version" does not include version at all! E.g. could be

❯ python -c 'from hed._version import get_versions; print(get_versions())'
{'version': '0+untagged.2400.g10fe30e', ...

after this fix

❯ python -c 'from hed._version import get_versions; print(get_versions())'
{'version': '0.5.0+145.g10fe30e1.dirty', ...

Without it "version" does not include version at all! E.g. could be

    ❯ python -c 'from hed._version import get_versions; print(get_versions())'
    {'version': '0+untagged.2400.g10fe30e', ...

after this fix

    ❯ python -c 'from hed._version import get_versions; print(get_versions())'
    {'version': '0.5.0+145.g10fe30e1.dirty', ...
@VisLab VisLab merged commit 61664e9 into hed-standard:master Oct 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants