-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite of tokenizer and introduction of object-based test cases #208
Conversation
… into update-spec
… into update-spec
@happy5214 I have updated and moved the converter tests to the tests directory. I am going to go ahead and merge to the develop branch. I also corrected a bug in the In the next PR, I am going to convert some more of the |
@happy5214 Could you please review --- I think this should be merged with develop and soon with master. Summary:
|
Revised the PR to not treat a missing HED column in tsv as an error when {HED} is used. |
We walked through these changes during a Zoom meeting. |
This PR represents a rewrite of the tokenizer, which is the syntax parser for hedstrings. The tokenizer now catches errors from bad slashes and blanks in addition to errors caught in the previous parser. An object based data framework for the test cases was introduced to make it easy to add testcases for the tokenizer.
A start was also made on converting the bids.spec tests to the object framework for clearer description of what was being tested and for possible porting to the Python validator for test cases.