Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use commaMissing issue for missing comma before tag group #170

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Use commaMissing issue for missing comma before tag group #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion parser/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ const findDelimiterIssuesInHedString = function (hedString) {
if (currentTag.trim() === openingGroupCharacter) {
currentTag = ''
} else {
issues.push(generateIssue('invalidTag', { tag: currentTag }))
issues.push(generateIssue('commaMissing', { tag: currentTag }))
}
} else if (isCommaMissingAfterClosingParenthesis(lastNonEmptyValidCharacter, currentCharacter)) {
issues.push(
Expand Down
2 changes: 1 addition & 1 deletion tests/event.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ describe('HED string and event validation', () => {
'/Action/Reach/To touch,(/Attribute/Object side/Left,/Participant/Effect/Body part/Arm,(/Attribute/Location/Screen/Top/70 px,/Attribute/Location/Screen/Left/23 px)),Event/Duration/3 ms',
}
const expectedIssues = {
missingOpeningComma: [generateIssue('invalidTag', { tag: '/Action/Reach/To touch(' })],
missingOpeningComma: [generateIssue('commaMissing', { tag: '/Action/Reach/To touch(' })],
missingClosingComma: [
generateIssue('commaMissing', {
tag: '/Participant/Effect/Body part/Arm)',
Expand Down