Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to BIDS interface #158

Merged
merged 10 commits into from
Jul 10, 2024
Merged

Add to BIDS interface #158

merged 10 commits into from
Jul 10, 2024

Conversation

happy5214
Copy link
Member

This PR adds to the BIDS API in hed-validator by directly exporting the per-type validators (JSON sidecar and TSV), as well as the BIDS schema loader. It also merges the HED column validation into the TSV validator. As a simplification, several new default exports have been added.

…alidators and schema loader

Also add more default exports.
@happy5214 happy5214 self-assigned this Jun 28, 2024
@happy5214 happy5214 added enhancement New feature or request bids BIDS integration labels Jun 28, 2024
@happy5214 happy5214 requested a review from VisLab June 28, 2024 14:06
Copy link
Member

@VisLab VisLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@happy5214 the passing of the validator classes to the different types of bids files really simplified the code. If all the tests pass please go ahead with the release.

@happy5214 happy5214 added this to the 3.15.0 milestone Jul 10, 2024
@happy5214 happy5214 merged commit 3059758 into master Jul 10, 2024
6 of 7 checks passed
@happy5214 happy5214 deleted the modify-bids-interface branch July 10, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bids BIDS integration enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants