-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for merging lazy partnered schemas #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happy5214
force-pushed
the
lazy-partnered-schemas
branch
from
April 26, 2024 14:46
d37b475
to
cb412d0
Compare
Also add missing code to regenerate Mapping object after merging schemas.
happy5214
force-pushed
the
lazy-partnered-schemas
branch
from
May 10, 2024 14:32
03607ca
to
6de5fc7
Compare
VisLab
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes were more substantial than I had first thought --- but it looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bids
BIDS integration
enhancement
New feature or request
hed 3
HED 3-specific issues
important
Important issues
schema
Schema parsing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for merging partnered schemas with the same
withStandard
XML attribute into the sameSchema
object, thereby treating them as a single schema. It provides the required validation of schema compatibility, the code to actually merge the data, and tests.