Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TSV validation event-based #143

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Make TSV validation event-based #143

merged 2 commits into from
Mar 8, 2024

Conversation

happy5214
Copy link
Member

This PR merges TSV rows with the same onset into a single BidsTsvEvent object (for timeline TSV files only) and sorts them by their onset value.

@happy5214 happy5214 added enhancement New feature or request bids BIDS integration important Important issues labels Mar 8, 2024
@happy5214 happy5214 added this to the 3.14.0 milestone Mar 8, 2024
@happy5214 happy5214 requested a review from VisLab March 8, 2024 16:57
@happy5214 happy5214 self-assigned this Mar 8, 2024
@happy5214 happy5214 linked an issue Mar 8, 2024 that may be closed by this pull request
Use TSV event times in temporal tag validation #131
Closed
VisLab
VisLab approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@VisLab VisLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we went over in code review --- this looks good. Noted the use of lodash identity. May need to replace if incompatible with deno.

@happy5214 happy5214 merged commit 83be143 into master Mar 8, 2024
7 checks passed
@happy5214 happy5214 deleted the bids-tsv-event branch March 8, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VisLab VisLab VisLab approved these changes

Assignees

@happy5214 happy5214

Labels
bids BIDS integration enhancement New feature or request important Important issues
Projects
None yet
Milestone
3.13.4
Development

Successfully merging this pull request may close these issues.

Use TSV event times in temporal tag validation
2 participants
@happy5214 @VisLab