Implement support for curly braces #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix typo in unbalanced parentheses issue names.
happy5214
added
enhancement
happy5214
force-pushed
the
curly-braces
branch
from
ca03f5c to
7a24f99
Compare
Also fix two bugs with issue generation.
Also standardize return and yield JSDoc tags
Substitutions are now inlined.
Also create new class structure for tokenizer specs.
Also split mapping generation to new private method.
Also fix minor typo.
Also fix test issue in previous commit.
- Split bids/types.js into several files. - Move curly brace mapping generation to BidsSidecar. - Fix test issue. - Don't include columns spliced through curly braces in combined string.
Also comment out failing test issues.
Also add tests for "n/a" deletion.
Also add documentation for buildBidsSchemas.
Also re-enable two tests in stringParser module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for curly braces in sidecars, as described in https://hed-specification.readthedocs.io/en/develop/03_HED_formats.html#sidecar-curly-braces. It is not done yet.