Allow basic auth to be optional in apache conf

[patcon]

We could add some logic so that if either attr basic_auth_username or basic_auth_password are nil, htpasswd and the relevant section of the apache conf are not written.

Will attach code later if I do this.

[patcon]

If this works for you so far, any objection to removing a layer of indirection and moving the simple htpasswd template into a file resource within recipe[jenkins::proxy_apache2]?

[patcon]

And to explain, there was some odd behavior in chef roles that were written in ruby, and so nil values weren't even recognized and the defaults were instead utilized. Might have something to do with the unintuitive way the chef thinks of default, normal and override, but just thought it simpler to go with empty strings and doc it.

Would only ever be an issue if the default username/password in the recipe were switched to nil instead of jenkins/jenkins, as that would error when checking if a nil value was .empty?

[agh]

👍

[agh]

Am I to read into this that the standard procedure for Pull Requests is now to not bother reviewing them or providing any feedback, and then to summarily close them after 6+ months? 😸

[chrisroberts]

@agh please see the readme in the repo root. This cookbook is now being maintained by opscode and has been moved.

[patcon]

#23