Graphql module fails as slingfeature #1184
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm currently playing around building my own feature-model with Peregrine on top.
Had a problem in platform/graphql/ui.apps that wasn't starting.
With my new approach (starting from sling-archetype instead of forking the sling-starter) it's already predicting that on build-time:
[ERROR] Failed to execute goal org.apache.sling:slingfeature-maven-plugin:1.8.2:analyse-features (prepare-features) on project launcher: Exception during analysing feature org.motorbrot:launcher:slingosgifeature:app:1.0-SNAPSHOT : graphql-java-15.0.jar has no maven coordinates!
I was able to fix that by replacing the wcmio-content-package-maven-plugin by jackrabbit's filevault-package-maven-plugin.
So I feel obliged to contribute back to this amazing but underappreciated project.
Change is only on the problematic graphql module.
It's only for the part of building the content-packages, wcm.io one still can be used for up/downloading content. [1]
I was starting to change everything, but that would be a lot of changes. Maybe I can pick this up later. [2]
It's not necessary to start Peregrine via slingfeature-maven-plugin.
[1] https://wcm-io.atlassian.net/wiki/spaces/WCMIO/pages/91586585/Migrate+content+package+projects+from+wcmio-content-package-maven-plugin+to+Jackrabbit+filevault-package-maven-plugin
[2] https://wcm-io.atlassian.net/wiki/spaces/WCMIO/pages/1353056261/How+to+make+your+content+packages+comply+with+Jackrabbit+FileVault+Validation