Article css issues #269
Merged
Article css issues #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loop/, fixed CSS issues, fixed more cards bug, linting
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
|
|
fixing seperators on long-form articles linting
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
icaraps
reviewed
Sep 28, 2023
| const canonicalLinkTag = document.head.querySelector('link[rel="canonical"]'); | ||
| if (canonicalLinkTag) { | ||
| const longPathMetadata = document.createElement('meta'); | ||
| longPathMetadata.setAttribute('property', 'hlx:long-form-path'); |
There was a problem hiding this comment.
@DriftingSands this property will exist and be named "path" once @hsaginor reimports the whole content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed loop-trending-banner issues and added it to articles from /the-loop/,
fixed more article CSS issues,
fixed more-cards bug,
linting
Test URLs:
Before: https://main--helix-sportsmagazine--headwirecom.hlx.page/the-loop
After: https://article-css-issues--helix-sportsmagazine--headwirecom.hlx.page/the-loop
Before: https://main--helix-sportsmagazine--headwirecom.hlx.page/content-v2/the-loop/_default/article/2023/7/woman-hits-first-hole-in-one-hours-after-being-laid-off-reddit
After: https://article-css-issues--helix-sportsmagazine--headwirecom.hlx.page/content-v2/the-loop/_default/article/2023/7/woman-hits-first-hole-in-one-hours-after-being-laid-off-reddit
Before: https://main--helix-sportsmagazine--headwirecom.hlx.page/content-v2/play/courses/_default/article/2023/5/us-open-2023-los-angeles-country-club-north-course-return
After: https://article-css-issues--helix-sportsmagazine--headwirecom.hlx.page/content-v2/play/courses/_default/article/2023/5/us-open-2023-los-angeles-country-club-north-course-return
Before: https://main--helix-sportsmagazine--headwirecom.hlx.page/content-v2/play/courses/_default/article/2023/5/golf-trip-how-to-plan-interactive
After: https://article-css-issues--helix-sportsmagazine--headwirecom.hlx.page/content-v2/play/courses/_default/article/2023/5/golf-trip-how-to-plan-interactive