Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid slashes in names of Groups and Datasets #1219

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Conversation

bendichter
Copy link
Contributor

@bendichter bendichter commented Dec 12, 2024

  • add checks to ensure that name and default name args do not contain slashes.
  • include tests

Motivation

We want to make sure people don't create extensions that contain names or default names that contain slashes.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

@bendichter bendichter requested a review from rly December 12, 2024 12:07
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.00%. Comparing base (a3c1998) to head (3fef9ec).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1219   +/-   ##
=======================================
  Coverage   89.00%   89.00%           
=======================================
  Files          45       45           
  Lines        9965     9969    +4     
  Branches     2831     2833    +2     
=======================================
+ Hits         8869     8873    +4     
  Misses        774      774           
  Partials      322      322           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bendichter bendichter merged commit d63e588 into dev Jan 9, 2025
29 checks passed
@bendichter bendichter deleted the validate-name-args branch January 9, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants