Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛑 Catch toast notification error in unpackaged app #38

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

haydenmc
Copy link
Owner

This is a workaround for #37

Toast notifications are not supported for unpackaged apps using the ToastNotifier. Instead of crashing, this change emits a log warning.

Eventually the WindowsAppSDK notification APIs should be used instead, which support both packaged and unpackaged apps.

@haydenmc haydenmc merged commit c166f3f into main Nov 15, 2024
1 check passed
@haydenmc haydenmc deleted the fix-unpackaged-notification branch November 15, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant