feat: upgrade to Patternfly v5 #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grgrzybek
approved these changes
May 21, 2024
tadayosi
reviewed
May 21, 2024
packages/hawtio/src/plugins/shared/operations/OperationForm.tsx
Outdated
Show resolved
Hide resolved
packages/hawtio/src/plugins/shared/operations/OperationForm.tsx
Outdated
Show resolved
Hide resolved
|
Thanks @tadayosi for careful review - I admit, I simply assumed Matej did the best. |
tadayosi
requested changes
May 21, 2024
packages/hawtio/src/plugins/shared/operations/OperationForm.tsx
Outdated
Show resolved
Hide resolved
Test resultsRun attempt: 1797
|
Well I did:), or at least I tried diven that time and space ;) |
Thanks for the review, as I mentioned you're right, I missed curried signatures of the functions. It also discovered other thing, and that is that are unit test suite could be better too. |
mmelko
force-pushed
the
patternfly-5-upgrade
branch
from
b177359 to
dcf0570
Compare
mmelko
force-pushed
the
patternfly-5-upgrade
branch
from
dcf0570 to
bdc8091
Compare
tadayosi
reviewed
May 29, 2024
mmelko
force-pushed
the
patternfly-5-upgrade
branch
3 times, most recently
from
2b79b66 to
df1ecb1
Compare
…ction signatures in the OperationForm and CamelPreferences testing-library version change, removal of unnecessary comments, change icons color to status definitions delete jpeg barckgrounds and use svg instead, etc
mmelko
force-pushed
the
patternfly-5-upgrade
branch
from
df1ecb1 to
fcfd77b
Compare
tadayosi
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used
@patternfly/pf-codemodsto upgrade most of the things, then fixed errors and some warnings. And upgraded some tables. In the next iteration I will ged rid of the rest deprecated components, mainly Selects and Dropdowns.related to #477
branch: jsolovjo:e2e-fix-patternfly5-tests