Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adds noconsole rule to guard against casual console.log msgs #625 #626

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

phantomjinx
Copy link
Member

  • Uses eslint-disable-next-line to keep those instances where it makes sense to use console.[log|error]

issue #625

@phantomjinx phantomjinx requested a review from tadayosi October 19, 2023 13:25
@github-actions
Copy link

github-actions bot commented Oct 19, 2023

Test Results

    8 files  ±0      8 suites  ±0   57m 40s ⏱️ - 1m 57s
  59 tests ±0    58 ✔️ ±0  1 💤 ±0  0 ±0 
468 runs  ±0  460 ✔️ ±0  8 💤 ±0  0 ±0 

Results for commit 87a3688. ± Comparison against base commit fd12d90.

♻️ This comment has been updated with latest results.

@hawtio-ci
Copy link

hawtio-ci bot commented Oct 19, 2023

Test results

Run attempt: 684
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(16)-java(11)-firefox 59 58 1 0 0 472.129
results-quarkus-node(16)-java(17)-firefox 59 58 1 0 0 421.906
results-quarkus-node(18)-java(11)-firefox 59 58 1 0 0 474.463
results-quarkus-node(18)-java(17)-firefox 59 58 1 0 0 366.591
results-springboot-node(16)-java(11)-firefox 58 57 1 0 0 516.904
results-springboot-node(16)-java(17)-firefox 58 57 1 0 0 382.611
results-springboot-node(18)-java(11)-firefox 58 57 1 0 0 455.927
results-springboot-node(18)-java(17)-firefox 58 57 1 0 0 369.749

Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There are a few comments but otherwise it looks great.

.eslintrc.js Outdated Show resolved Hide resolved
packages/hawtio/scripts/generate-camel-svg-index.js Outdated Show resolved Hide resolved
packages/hawtio/scripts/generate-camel-svg-index.js Outdated Show resolved Hide resolved
packages/hawtio/src/core/logging.ts Outdated Show resolved Hide resolved
@tadayosi
Copy link
Member

@phantomjinx What's the current status of this?

…tio#625

* Uses eslint-disable-next-line to keep those instances where it makes
  sense to use console.[log|error]

issue hawtio#625
@tadayosi tadayosi merged commit 50a83c4 into hawtio:main Oct 24, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants