[HxSidebar] responsive collapsing #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se, reverted default border radius of SidebarItem to regular (was large), + docs adjustment
hakenr
changed the title
hakenr
reviewed
Nov 19, 2024
Havit.Blazor.Documentation/Pages/Components/HxSidebarDoc/HxSidebar_Demo_Colors.razor.css
Outdated
Show resolved
Hide resolved
hakenr
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #282 and #532.
What i did to fix #532
To hide the item content when the sidebar is collapsed, instead of conditional rendering with if statement, i am adding css utility classes that only hide the content on viewport larger than Sidebars ResponsiveBreakpoint setting and if resized below, it gets displayed again.
@hakenr I need two things from you to be able to complete this PR:
I have also overhauled Sidebars CSS vars so you can create color variations with utility classes and added respective demos and added flexbox layout to implement what was requested in #282.