Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix links to defaults #664

Merged
merged 1 commit into from
Nov 25, 2023
Merged

[docs] Fix links to defaults #664

merged 1 commit into from
Nov 25, 2023

Conversation

Harvey1214
Copy link
Member

@Harvey1214 Harvey1214 commented Nov 15, 2023

@hakenr currently, HxGrid.Defaults leads to a non-existent page, this commit adjusts the URL, so that it leads to the GridSettings type definition.

However, to be consistent with other links to properties, we should change the link to lead to the page of the type where the property is defined, in this example HxGrid.

And since we gained the support for hashed routing to named elements in .NET 8, I suggest we consider setting the Ids of members (properties, methods, ...) in the API documentation section to increase the usefulness of the links to component members.

image

@Harvey1214 Harvey1214 requested a review from hakenr November 15, 2023 15:52
@Harvey1214 Harvey1214 self-assigned this Nov 15, 2023
@hakenr hakenr merged commit c1bbfde into master Nov 25, 2023
1 check passed
@hakenr hakenr deleted the feauture/LinksToDefaults branch November 25, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants