[HxMultiSelect] Select all synchronisation #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakenr
requested changes
Oct 31, 2023
Havit.Blazor.Components.Web.Bootstrap/Forms/Internal/HxMultiSelectInternal.razor.cs
Outdated
Show resolved
Hide resolved
Havit.Blazor.Components.Web.Bootstrap/Forms/Internal/HxMultiSelectInternal.razor.cs
Outdated
Show resolved
Hide resolved
|
@hakenr I've made changes as per your review and am ready for a re-review. |
… code simplification
hakenr
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
@bholbrook I did some final adjustments and will merge to master.
- simplified the logic (sacrificed some of the perf-optimizations for now)
- extracted the
SynchronizeSelectAllCheckbox()method - fixed: ClearIcon did not synchronize the checkbox
I will probably simplify theSelectedValuessynchronization with outerHxMultiSelectthen.
Many thanks for your contribution!
We will add additional pre-release the lib today.
We plan to publish the 4.2.5 release later this week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
As per #638
Valuecontains all itemsMissed code from #617