Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev 1370 #25

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Dev 1370 #25

merged 7 commits into from
Dec 17, 2024

Conversation

Ronster2018
Copy link
Contributor

This project work consists of

  • adding the deploy workflow
  • updating the build workflow
    • Removed workflow_run due to this adding the latest tag auomatically
  • Updating the tag-release job to pull the repositories name since this seems to be called different names in different repositories and files.

contents: read
packages: write
steps:
- name: Deploy to workshop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use Deploy to ${{inputs.environments}}?

Copy link
Contributor

@liseli liseli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ronster2018 Updating mysqlclient to use the version 2.1.0 will fix the dependency issue of this workflow. I will create a new branch with this change and if we merge with your branch the problem will be solved. I will mention you and @aelkiss to review this fix

@Ronster2018 Ronster2018 merged commit 943be56 into main Dec 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants