Indexer service use Solr authentication to index documents & unites c… #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liseli
force-pushed
the
DEV-1349-solrAuth
branch
from
20150e9 to
ba320d1
Compare
aelkiss
approved these changes
Sep 24, 2024
|
|
||
| 1. Retriever service | ||
|
|
||
| `docker compose up document_retriever -d` |
There was a problem hiding this comment.
Could we define dependencies or profiles in docker compose to avoid needing to manually start all 3?
There was a problem hiding this comment.
I have created profiles for each service, and I also created different services in the docker-compose to group and independently run the tests of each service, but this solution started to fail running the tests in the github actions. For that reason, I abandoned it. I can add a GitHub issue to try it again in the future with K'Ron support.
carylwyatt
approved these changes
Sep 25, 2024
…hanged to avoid Solr authentication Profiles have been added to the docker-compose to start and test each of the service (retriever, generator, indexer) indendently, but I removed because it did not work well with the github actions & The Solr service has been updated to accept authentication and created the collection. Update README.md
liseli
force-pushed
the
DEV-1349-solrAuth
branch
from
92ab419 to
f0b72b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about this task, which aims to run the ht-indexer in Kubernetes (ICTC) using the new Solr cluster.
What changed?
These changes have been successfully tested in Kubernetes, as the following images show. I manually updated the ht-indexer image in the ht-tanka repository and defined SOLR_USER and SOLR_PASSWORD in the terminal.
How to test this PR
Note: For these tests, you can ignore the following Warning: the SOLR_USER and SOLR_PASSWORD environment variables are not set.
To approve this PR, check all the tests passed in your terminal.
document_retriever: 25 passed
document_generator: 29 passed
document_indexer: 12 passed