DEV-1124: holdings are equal if fields are equal or both empty #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelkiss
commented
May 3, 2024
spec/clusterable/holding_spec.rb
Outdated
| end | ||
|
|
||
| (described_class.fields.keys - ["date_received", "uuid", "_id"]).each do |attr| | ||
| it "== is false if #{attr} doesn't match" do | ||
| h2[attr] = nil | ||
| expect(h == h2).to be(false) | ||
| # ensure attribute in h2 is different from h but |
There was a problem hiding this comment.
Before, we were always setting h2[attr] to nil, so the behavior change made this test fail -- now it sets it to an appropriate non-nil but non-equal type.
mwarin
reviewed
May 6, 2024
mwarin
approved these changes
May 6, 2024
… blank The holdings matching function used update_key (a modified hash value) rather than equality; this update folds empty string & nil for computing that update_key as well.
|
@mwarin I added a test to cover the actual update situation, which revealed that for performance we were using |
mwarin
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address the underlying issue we were seeing with duplicate holdings not being cleaned up.
It probably would not hurt to add a test case that exercises the specific issue we were seeing -- create a cluster with a holding with some nil fields, update it with a holding with corresponding empty-string fields; ensure that they match and it doesn't end up with duplicate holdings. I will work on that next week, but wanted to get something up for a look now.