bugfix for DEV-562: make SharedPrint::Finder phase queries more specific #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwarin
changed the title
mwarin
force-pushed
the
finder-phase-fix
branch
from
f470cfc to
47c2209
Compare
moseshll
reviewed
Oct 26, 2023
moseshll
approved these changes
Oct 26, 2023
mwarin
force-pushed
the
finder-phase-fix
branch
from
c6f277e to
37fb01d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further fix for: https://hathitrust.atlassian.net/browse/DEV-562
SharedPrint::Finder.new(phase: [x]).commitmentsshould only yield commitments withphase: x, but the released code was missing a condition and was erroneously yielding all commitments in a cluster if any one of the commitments in the cluster hadphase: x.This PR adds that missing condition and adds the tests to prove it's doing the right thing.