standardrb fixes

globally ignore "unreachable code" from the raise "not implemented"
stuff

.standard.yml

@@ -0,0 +1,3 @@
+ignore:
+  - 'lib/**/*':
+    - Lint/UnreachableCode

lib/clusterable/ocn_resolution.rb

@@ -3,21 +3,21 @@
 module Clusterable
   # A mapping from a deprecated OCN to a resolved OCN
   class OCNResolution
-#    include Mongoid::Document
-#
-#    # store_in collection: "resolutions", database: "test", client: "default"
-#    field :deprecated
-#    field :resolved
-#    field :ocns, type: Array
-#
-#    embedded_in :cluster
-#    validates :deprecated, uniqueness: true
-#    validates_presence_of :deprecated, :resolved, :ocns
-#    index(ocns: 1)
-#
-#    scope :for_cluster, lambda { |_cluster|
-#      where(:$in => ocns)
-#    }
+    #    include Mongoid::Document
+    #
+    #    # store_in collection: "resolutions", database: "test", client: "default"
+    #    field :deprecated
+    #    field :resolved
+    #    field :ocns, type: Array
+    #
+    #    embedded_in :cluster
+    #    validates :deprecated, uniqueness: true
+    #    validates_presence_of :deprecated, :resolved, :ocns
+    #    index(ocns: 1)
+    #
+    #    scope :for_cluster, lambda { |_cluster|
+    #      where(:$in => ocns)
+    #    }
 
     def ==(other)
       self.class == other.class && deprecated == other.deprecated && resolved == other.resolved

spec/clusterable/holding_spec.rb

@@ -61,24 +61,24 @@
     end
 
     # can't just skip -- fields is not defined
-#    (described_class.fields.keys - ["date_received", "uuid", "_id"]).each do |attr|
-#      it "== is false if #{attr} doesn't match" do
-#        # ensure attribute in h2 is different from h but
-#        # of the same logical type
-#
-#        case h[attr]
-#        when String
-#          h2[attr] = "#{h[attr]}junk"
-#        when Numeric
-#          h2[attr] = h[attr] + 1
-#        when true, false, nil
-#          h2[attr] = !h[attr]
-#        end
-#
-#        expect(h[attr]).not_to eq(h2[attr])
-#        expect(h).not_to eq(h2)
-#      end
-#     end
+    #    (described_class.fields.keys - ["date_received", "uuid", "_id"]).each do |attr|
+    #      it "== is false if #{attr} doesn't match" do
+    #        # ensure attribute in h2 is different from h but
+    #        # of the same logical type
+    #
+    #        case h[attr]
+    #        when String
+    #          h2[attr] = "#{h[attr]}junk"
+    #        when Numeric
+    #          h2[attr] = h[attr] + 1
+    #        when true, false, nil
+    #          h2[attr] = !h[attr]
+    #        end
+    #
+    #        expect(h[attr]).not_to eq(h2[attr])
+    #        expect(h).not_to eq(h2)
+    #      end
+    #     end
   end
 
   describe "#same_as?" do

spec/clustering/cluster_holding_spec.rb

@@ -138,7 +138,6 @@ def new_submission(holding, date: Date.today)
         expect { described_class.new(h2).cluster }.to raise_exception(/same UUID/)
       end
     end
-
   end
 
   describe "#delete" do

spec/enum_chron_spec.rb

@@ -4,12 +4,12 @@
 require "enum_chron"
 
 class DummyRecord
-#  include Mongoid::Document
-#  include EnumChron
-#  field :enum_chron
-#  field :n_enum
-#  field :n_chron
-#  field :n_enum_chron
+  #  include Mongoid::Document
+  #  include EnumChron
+  #  field :enum_chron
+  #  field :n_enum
+  #  field :n_chron
+  #  field :n_enum_chron
 end
 
 RSpec.xdescribe EnumChron do