Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline mode API with cabal flag #52

Closed
wants to merge 5 commits into from

Conversation

GulinSS
Copy link

@GulinSS GulinSS commented Nov 6, 2023

It is based on existing PR with origin commits preserved.

Also, according to the comment, it implies that the default is to enable the new functions.

P.S. Origin commits by @robx contain changes to CI. I am not sure what is right, so, I left them as is. Let me known if some changes are required.

@GulinSS GulinSS mentioned this pull request Nov 6, 2023
@GulinSS
Copy link
Author

GulinSS commented Nov 8, 2023

Hi, @phadej! Can you help me to move this forward?

@nikita-volkov
Copy link

Hey @phadej! Sorry for having to ping. Could you help us get this merged or at least approximate when you'll be able to look into this?

@phadej
Copy link
Collaborator

phadej commented Dec 5, 2023

Sorry for having to ping. Could you help us get this merged or at least approximate when you'll be able to look into this?

Next year

EDIT: more precisely, when postgresql-libpq-0.10 has been in stackage LTS for a while, so I can be sure the changes there have been tried out widely. I have no intention to introduce major versions of postgresql-libpq more often than once a year. And postgresql-lib-0.10 has been released in July 2023.

@GulinSS
Copy link
Author

GulinSS commented Mar 5, 2024

@phadej, next year is now.

And postgresql-lib-0.10 has been released in July 2023.

Does it mean you would expect us wait to stuck these changes up to July 2024?

@nikita-volkov
Copy link

@phadej Unfortunately this blocks us in development of pipelining mode for Hasql. Is there any way we could move this forward earlier? It really doesn't seem to be reasonable to introduce a fork simply due to scheduling issues.

@phadej
Copy link
Collaborator

phadej commented Apr 16, 2024

The next thing is to add support for GHC-9.10 (for everything, not only this lib), let's see after then.

If you feel you need to fork, I won't be offended, OSS is meant to be a bazaar not a catherdal.

@nikita-volkov
Copy link

Okay. Thanks for quick response.

@iand675
Copy link

iand675 commented Aug 9, 2024

Hi, it's August now. Are you able to ship some version of it now that a year has passed?

@phadej
Copy link
Collaborator

phadej commented Aug 13, 2024

Yes. But I'm pondering what to do with pkgconfig stuff. Having dependency bounds on the underlying libpq would make things a lot easier, but there isn't usually libpq in pkgconfig databases on windows or macos.

@phadej
Copy link
Collaborator

phadej commented Aug 19, 2024

pkgconfig stuff figure out, I'll take a look at this later this week.

@phadej phadej mentioned this pull request Aug 24, 2024
@phadej phadej closed this in #64 Aug 24, 2024
@phadej
Copy link
Collaborator

phadej commented Aug 24, 2024

Released in https://hackage.haskell.org/package/postgresql-libpq-0.11.0.0

@GulinSS GulinSS deleted the pipeline-up branch August 26, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants