Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OSV schema validation #254

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add OSV schema validation #254

wants to merge 2 commits into from

Conversation

TristanCacqueray
Copy link
Collaborator

@TristanCacqueray TristanCacqueray commented Nov 27, 2024 •
edited
Loading

Fixes: #251

@TristanCacqueray TristanCacqueray force-pushed the osv-validation branch 2 times, most recently from 9710cfb to 7d78c83 Compare November 27, 2024 21:48
@TristanCacqueray TristanCacqueray marked this pull request as draft November 27, 2024 22:05
@TristanCacqueray TristanCacqueray force-pushed the osv-validation branch 3 times, most recently from 8aa5eb0 to 427cb5e Compare December 11, 2024 20:01
@TristanCacqueray TristanCacqueray marked this pull request as ready for review December 11, 2024 20:09
@TristanCacqueray
Copy link
Collaborator Author

This works as expected, as demonstrated in #257

blackheaven
blackheaven requested changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@blackheaven blackheaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do it without changing flake.nix

blackheaven
blackheaven requested changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@blackheaven blackheaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So close :)

.github/workflows/nix.yml Outdated Show resolved Hide resolved
@TristanCacqueray @blackheaven
Update .github/workflows/nix.yml
973b3eb 
Co-authored-by: Gautier DI FOLCO <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackheaven blackheaven blackheaven requested changes

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Perform OSV JSON Schema validation as part of record conversion
3 participants
@TristanCacqueray @mihaimaruseac @blackheaven