Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html: fix missing <tr> on by-packages index #228

Merged

Conversation

frasertweedale
Copy link
Collaborator

@frasertweedale frasertweedale commented Jul 30, 2024

Presentation of packages/components that have multiple advisories is corrupted, due to missing parent elements. Data cells for multiple advisories are appearing in a single row. Add missing elements.

Before:

image

After:

image


Advisory

  • It's not duplicated
  • All fields are filled
  • It is validated by hsec-tools

hsec-tools

  • Previous advisories are still valid

Presentation of packages/components that have multiple advisories is
corrupted, due to missing <tr> parent elements.  Data cells for
multiple advisories are appearing in a single row.  Add missing <tr>
elements.
Copy link
Collaborator

@blackheaven blackheaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it change the display?

@frasertweedale
Copy link
Collaborator Author

Does it change the display?

Yes; I updated the PR description with before/after screenshots.

@frasertweedale frasertweedale merged commit bdaf454 into haskell:main Jul 30, 2024
8 checks passed
@frasertweedale frasertweedale deleted the fix/html-by-package-missing-tr branch July 30, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants