Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CVSS v2 prefix from vector string #218

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Remove CVSS v2 prefix from vector string #218

merged 4 commits into from
Jul 19, 2024

Conversation

TristanCacqueray
Copy link
Collaborator

@TristanCacqueray TristanCacqueray commented Jul 12, 2024 •
edited
Loading

This change fix the OSV export.

Fixes #217

hsec-tools

  • Previous advisories are still valid

blackheaven
blackheaven reviewed Jul 12, 2024
View reviewed changes
code/cvss/test/Spec.hs Outdated Show resolved Hide resolved
@blackheaven
Copy link
Collaborator

I'll handle the CI issue

@TristanCacqueray TristanCacqueray force-pushed the cvss2-fix branch 2 times, most recently from 98df552 to f19b28f Compare July 12, 2024 11:25
@TristanCacqueray
Copy link
Collaborator Author

Thanks, and I applied the stripPrefix suggestion.

@frasertweedale
Copy link
Collaborator

I'm addressing the CI issues in #220 .

frasertweedale
frasertweedale approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@frasertweedale frasertweedale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion. And we will also need to rebase on main to pick up the CI fixes.

@TristanCacqueray
Fix CVSS v2 vector string by dropping the version prefix
eb8f7c1 
This change fix the OSV export.
@TristanCacqueray
Detect unknown CVSS version
988f39e 
This change ensures the UnknownVersion exception is returned for
unknown cvss version prefix.
@frasertweedale frasertweedale merged commit d09058a into haskell:main Jul 19, 2024
8 checks passed
@frasertweedale frasertweedale mentioned this pull request Jul 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frasertweedale frasertweedale frasertweedale approved these changes

@blackheaven blackheaven blackheaven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

osv: CVSS v2 vector string should not include version prefix
3 participants
@TristanCacqueray @blackheaven @frasertweedale